From 252674c5bf74e7c4e6e94dffb251c2f0133de046 Mon Sep 17 00:00:00 2001
From: Ruidy Nemausat <ruidy.nemausat@gmail.com>
Date: Thu, 14 May 2020 12:26:21 +0200
Subject: [PATCH] extract useForm hook

---
 src/hooks/index.tsx  | 28 ++++++++++++++++++++++++++++
 src/pages/SignUp.tsx | 28 ++++++++++++++--------------
 2 files changed, 42 insertions(+), 14 deletions(-)
 create mode 100644 src/hooks/index.tsx

diff --git a/src/hooks/index.tsx b/src/hooks/index.tsx
new file mode 100644
index 0000000..84809c3
--- /dev/null
+++ b/src/hooks/index.tsx
@@ -0,0 +1,28 @@
+import {useState, ChangeEvent} from 'react';
+
+/**
+ * provide onChange handler and reset function
+ * T is the initFormData object type
+ *
+ * @param initFormData initial state of the form
+ * @returns formData object,
+ * @returns handleChange function to pass to input tag
+ * @returns resetForm function to revert to initFormData
+ * */
+const useForm = <T,>(initFormData: T) => {
+  const [formData, setFormData] = useState<T>(initFormData);
+
+  /** update each input state value onChange */
+  const handleChange = (e: ChangeEvent<HTMLInputElement>): void =>
+    setFormData({
+      ...formData,
+      [e.target.name]: e.target.value,
+    });
+
+  /** clean form after successful submition */
+  const resetForm = () => setFormData(initFormData);
+
+  return {formData, handleChange, resetForm};
+};
+
+export default useForm;
diff --git a/src/pages/SignUp.tsx b/src/pages/SignUp.tsx
index 2f9d3e8..4044a29 100644
--- a/src/pages/SignUp.tsx
+++ b/src/pages/SignUp.tsx
@@ -13,6 +13,7 @@ import Header from '../components/Header';
 import {FontAwesomeIcon} from '@fortawesome/react-fontawesome';
 import {faExclamationTriangle} from '@fortawesome/free-solid-svg-icons';
 import GoogleButton from 'react-google-button';
+import useForm from '../hooks';
 
 // extends withFirebaseProps type to ad profile info
 interface IProps extends WithFirebaseProps<User> {
@@ -20,32 +21,31 @@ interface IProps extends WithFirebaseProps<User> {
   isLoaded: boolean;
 }
 
+interface InitFormData {
+  name: string;
+  email: string;
+  password: string;
+  password2: string;
+}
 /**
  * Sign up form recieves firebase from withFirebase HOC
  */
 const SignUp: FC<IProps> = ({firebase, isEmpty, isLoaded}) => {
   const history = useHistory();
+  const [error, setError] = useState(false);
 
-  const initFormData = {
+  const initFormData: InitFormData = {
     name: '',
     email: '',
     password: '',
     password2: '',
-    error: false,
   };
-  const [formData, setFormData] = useState(initFormData);
 
-  /** update each input state value onChange */
-  const handleChange = (e: React.ChangeEvent<HTMLInputElement>): void =>
-    setFormData({
-      ...formData,
-      [e.target.name]: e.target.value,
-    });
+  const {formData, handleChange, resetForm} = useForm<InitFormData>(
+    initFormData,
+  );
 
-  /** clean form after successful submition */
-  const resetForm = () => setFormData(initFormData);
-
-  const {name, email, password, password2, error} = formData;
+  const {name, email, password, password2} = formData;
 
   // prevent submitting invalid forms
   const isDisabled: boolean = name === '' || email === '' || password === '';
@@ -54,7 +54,7 @@ const SignUp: FC<IProps> = ({firebase, isEmpty, isLoaded}) => {
   const handleSubmit = (e: React.FormEvent<HTMLFormElement>) => {
     e.preventDefault();
     if (password !== password2) {
-      setFormData({...formData, error: true});
+      setError(true);
     } else {
       // pass the info to store into the second argument
       firebase