From 37344590b7825545136988cc121c60d0b38a6226 Mon Sep 17 00:00:00 2001
From: Ruidy Nemausat <ruidy.nemausat@gmail.com>
Date: Sun, 17 May 2020 13:56:30 +0200
Subject: [PATCH] profile-top

---
 src/models/Dev.ts     | 35 ++---------------------------------
 src/pages/Profile.tsx | 28 +++++++++++++++++++---------
 2 files changed, 21 insertions(+), 42 deletions(-)

diff --git a/src/models/Dev.ts b/src/models/Dev.ts
index 84583fa..21bd66c 100644
--- a/src/models/Dev.ts
+++ b/src/models/Dev.ts
@@ -39,10 +39,7 @@ export class Dev implements IDev {
   status = 'Developer';
   company = '';
   avatarUrl = '';
-  /** create profile tagline */
-  get description(): string {
-    return `${this.status} at ${this.company}`;
-  }
+  description = '';
   location = '';
   skills: string[] = [];
   links: Links = {
@@ -59,35 +56,6 @@ export class Dev implements IDev {
   educations: Education[] = [];
   repos: Repo[] = [];
 }
-//
-// export const getDescription = (status: string, company: string) =>
-//   `${status} at ${company}`;
-
-/**
- */
-// export const blankDev = {
-//   isActive: true,
-//   displayName: '',
-//   status: 'Developer',
-//   company: '',
-//   avatarUrl: '',
-//   description: '',
-//   location: '',
-//   skills: [],
-//   links: {
-//     website: '',
-//     instagram: '',
-//     facebook: '',
-//     linkedin: '',
-//     twitter: '',
-//     github: '',
-//     youtube: '',
-//   },
-//   bio: '',
-//   experiences: [],
-//   educations: [],
-//   repos: [],
-// };
 
 /**
  * sample Dev for development and tests
@@ -196,6 +164,7 @@ export const developers: DevSummary[] = [
     avatarUrl:
       'https://lh3.googleusercontent.com/a-/AOh14GhncH95MWKwPR3TRKy4eVd4n6w0-fobe4dhiam2xA',
     description: 'Fullstack Engineer at DESY',
+
     location: 'Hamburg, DE',
     skills: ['React', 'TypeScript', 'Redux', 'Nodejs'],
   },
diff --git a/src/pages/Profile.tsx b/src/pages/Profile.tsx
index 7499df9..aa8c8a9 100644
--- a/src/pages/Profile.tsx
+++ b/src/pages/Profile.tsx
@@ -16,6 +16,7 @@ import {
   faInstagram,
   faLinkedin,
   faTwitter,
+  faYoutube,
 } from '@fortawesome/free-brands-svg-icons';
 import {
   faGlobe,
@@ -26,7 +27,7 @@ import {
   faCodeBranch,
 } from '@fortawesome/free-solid-svg-icons';
 // Typing
-import Dev from '../models/Dev';
+import {Dev} from '../models/Dev';
 import Experience from '../types/Experience';
 import {getTimePeriod} from '../types/TimePeriod';
 import Education from '../types/Education';
@@ -58,6 +59,8 @@ const Profile: FC<IProps> = ({dev}) => {
         return faLinkedin;
       case 'twitter':
         return faTwitter;
+      case 'youtube':
+        return faYoutube;
       default:
         return faGlobe;
     }
@@ -74,19 +77,26 @@ const Profile: FC<IProps> = ({dev}) => {
       <div className="profile-grid my-1">
         <div className="profile-top bg-primary p-2">
           <img
-            src="https://www.gravatar.com/avatar/205e460b479e2e5b48aec07710c08d50?s=200"
-            alt="Some guy"
+            src={dev.avatarUrl}
+            alt={dev.displayName}
             className="round-img my-1"
           />
           <h1 className="large">{dev.displayName}</h1>
-          <p className="lead">{dev.description}</p>
+          <p className="lead">{`${dev.status} at ${dev.company}`}</p>
           <p>{dev.location}</p>
           <div className="icons my-1">
-            {/* {Object.entries(dev.links).map(([icon, webAddress], i: number) => (
-              <a href={webAddress} key={i}>
-                <FontAwesomeIcon icon={renderSocialIcon(icon)} size="2x" />
-              </a>
-            ))} */}
+            {Object.entries(dev.links)
+              .sort()
+              .map(([icon, webAddress], i: number) => (
+                <a
+                  href={webAddress}
+                  key={i}
+                  target="_blank"
+                  rel="noopener noreferrer"
+                >
+                  <FontAwesomeIcon icon={renderSocialIcon(icon)} size="2x" />
+                </a>
+              ))}
           </div>
         </div>