From 7a0850bc1aafec2ee30174e732bc1724532ead49 Mon Sep 17 00:00:00 2001 From: Ruidy Date: Fri, 21 Jan 2022 16:50:21 -0400 Subject: [PATCH] fix: ineffassign in handlers --- api/handlers.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/api/handlers.go b/api/handlers.go index 1dd0f36..8700743 100644 --- a/api/handlers.go +++ b/api/handlers.go @@ -14,12 +14,11 @@ func (s Server) HandleNewPassword(w http.ResponseWriter, r *http.Request) { if err := render.Bind(r, params); err != nil { log.Fatal(err) } - - password := passgen.NewPasswordGenerator(passgen.Options{Length: params.Length, - WithNumbers: params.WithNumbers}).NewPassword() + opts := passgen.Options{Length: params.Length, WithNumbers: params.WithNumbers} + password := passgen.NewPasswordGenerator(opts.SetDefaults()).NewPassword() render.Status(r, http.StatusAccepted) - err := render.Render(w, r, &PasswordResponse{Password: password, Success: true}) + err := render.Render(w, r, &PasswordResponse{Password: password}) if err != nil { log.Fatalf("error: %q", err) } @@ -40,7 +39,7 @@ type PasswordResponse struct { Password string `json:"password"` } -func (resp PasswordResponse) Render(http.ResponseWriter, *http.Request) error { +func (resp *PasswordResponse) Render(http.ResponseWriter, *http.Request) error { resp.Success = true return nil }