From f19874e4c766a1dc91b95e1950f6b6a090d227e8 Mon Sep 17 00:00:00 2001
From: Ruidy <ruidy.nemausat@gmail.com>
Date: Wed, 11 Dec 2024 18:34:41 +0100
Subject: [PATCH] add error handling

---
 README.md                      |  76 ++++++++++++++++-----------------
 TODO.md                        |   7 ++-
 app.vue                        |  13 ++++++
 bun.lockb                      | Bin 418401 -> 418401 bytes
 error.vue                      |  58 +++++++++++++++++++++++++
 pages/[id].vue                 |  13 +++++-
 server/api/recipes/[id].get.ts |  14 +++++-
 types/id.ts                    |   8 ++++
 8 files changed, 147 insertions(+), 42 deletions(-)
 create mode 100644 error.vue
 create mode 100644 types/id.ts

diff --git a/README.md b/README.md
index f4195b5..ade2e85 100644
--- a/README.md
+++ b/README.md
@@ -29,45 +29,45 @@ Free meal planner for cooks short on ideas! (like me …)
 - Search by name: you look for a recipe? Ours are easy to make and Yummy! ✓
 - What's in the fridge ? Choose your main ingredient and get a meal suggestion
 - Choose by a category: ✓
-    - Beef
-    - Breakfast
-    - Chicken
-    - Dessert
-    - Goat
-    - Lamb
-    - Miscellaneous
-    - Pasta
-    - Pork
-    - Seafood
-    - Side
-    - Starter
-    - Vegan
-    - Vegetarian
+  - Beef
+  - Breakfast
+  - Chicken
+  - Dessert
+  - Goat
+  - Lamb
+  - Miscellaneous
+  - Pasta
+  - Pork
+  - Seafood
+  - Side
+  - Starter
+  - Vegan
+  - Vegetarian
 - Choose by area:
-    - American
-    - British
-    - Canadian
-    - Chinese
-    - Dutch
-    - Egyptian
-    - French
-    - Greek
-    - Indian
-    - Irish
-    - Italian
-    - Jamaican
-    - Japanese
-    - Kenyan
-    - Malaysian
-    - Mexican
-    - Moroccan
-    - Russian
-    - Spanish
-    - Thai
-    - Tunisian
-    - Turkish
-    - Unknown
-    - Vietnamese
+  - American
+  - British
+  - Canadian
+  - Chinese
+  - Dutch
+  - Egyptian
+  - French
+  - Greek
+  - Indian
+  - Irish
+  - Italian
+  - Jamaican
+  - Japanese
+  - Kenyan
+  - Malaysian
+  - Mexican
+  - Moroccan
+  - Russian
+  - Spanish
+  - Thai
+  - Tunisian
+  - Turkish
+  - Unknown
+  - Vietnamese
 - Cocktail selection
 - Create a profile and save your favourite meals ✓
 - Notation system: know what are the most loved meals
diff --git a/TODO.md b/TODO.md
index de9f0fc..9d4bee6 100644
--- a/TODO.md
+++ b/TODO.md
@@ -7,7 +7,12 @@
 - [x] deploy
 - [x] nuxt image
 - [x] prettier and eslint
-- [ ] transition
+- [ ] transition and loading times
 - [ ] pwa
 - [ ] seo, robots.txt
 - [x] update the README
+- [ ] create image provider
+- [ ] fetch recipe per id
+- [ ] add mood section
+  - [ ] store recipes into my db (SQLite)
+  - [ ] process them using AI
diff --git a/app.vue b/app.vue
index ddc2027..5f597d2 100644
--- a/app.vue
+++ b/app.vue
@@ -7,3 +7,16 @@
     <AppFooter />
   </div>
 </template>
+
+<style>
+.page-enter-active,
+.page-leave-active {
+  transition: all 0.4s;
+}
+
+.page-enter-from,
+.page-leave-to {
+  opacity: 0;
+  filter: blur(1rem);
+}
+</style>
diff --git a/bun.lockb b/bun.lockb
index d7cc001e447830509b67ca7129b60b22b44b4c88..bb8092e20f80206cc913a6e3d54236c7fb1115c7 100755
GIT binary patch
delta 40
ucmaEOMDpPg$%Yoj7N!>FEiBo#9E@?sdPc^27VX8hEI`b<z1WuRoeBUe$qje_

delta 40
qcmaEOMDpPg$%Yoj7N!>FEiBo#983%l&|YlI0>rG_i*4E7sQ>^Ev<vS5

diff --git a/error.vue b/error.vue
new file mode 100644
index 0000000..4918d99
--- /dev/null
+++ b/error.vue
@@ -0,0 +1,58 @@
+<template>
+  <div class="min-h-screen flex items-center justify-center bg-base-200">
+    <div class="text-center max-w-md p-8">
+      <div class="card bg-base-100 shadow-xl">
+        <div class="card-body">
+          <!-- Error Icon -->
+          <div class="text-error text-6xl mb-4">
+            <svg
+              xmlns="http://www.w3.org/2000/svg"
+              class="mx-auto h-24 w-24"
+              fill="none"
+              viewBox="0 0 24 24"
+              stroke="currentColor"
+            >
+              <path
+                stroke-linecap="round"
+                stroke-linejoin="round"
+                stroke-width="2"
+                d="M12 9v2m0 4h.01m-6.938 4h13.856c1.54 0 2.502-1.667 1.732-3L13.732 4c-.77-1.333-2.694-1.333-3.464 0L3.34 16c-.77 1.333.192 3 1.732 3z"
+              />
+            </svg>
+          </div>
+
+          <!-- Error Details -->
+          <h1 class="text-4xl font-bold mb-4">
+            {{ error?.statusCode || "Error" }}
+          </h1>
+          <p class="text-xl mb-6">
+            {{ error?.message || "Something went wrong" }}
+          </p>
+
+          <!-- Action Buttons -->
+          <div class="flex justify-center gap-4">
+            <button class="btn btn-primary" @click="handleError">
+              Try Again
+            </button>
+            <button class="btn btn-ghost" @click="navigateToHome">
+              Go Home
+            </button>
+          </div>
+        </div>
+      </div>
+    </div>
+  </div>
+</template>
+
+<script setup>
+const error = useError();
+const route = useRoute();
+
+const handleError = () => {
+  clearError({ redirect: route.redirectedFrom?.fullPath ?? "/" });
+};
+
+const navigateToHome = () => {
+  clearError({ redirect: "/" });
+};
+</script>
diff --git a/pages/[id].vue b/pages/[id].vue
index 17688d7..5234871 100644
--- a/pages/[id].vue
+++ b/pages/[id].vue
@@ -1,6 +1,17 @@
 <script setup lang="ts">
+import { idSchema } from "~/types/id";
+
 const { params } = useRoute();
-const id = params.id;
+const routeParam = params.id;
+
+const parsed = idSchema.safeParse(routeParam);
+
+if (!parsed.success) {
+  throw createError({
+    statusCode: 400,
+    statusMessage: "Invalid recipe id",
+  });
+}
 
 const {
   data: recipe,
diff --git a/server/api/recipes/[id].get.ts b/server/api/recipes/[id].get.ts
index 4f8f61c..d035d26 100644
--- a/server/api/recipes/[id].get.ts
+++ b/server/api/recipes/[id].get.ts
@@ -1,12 +1,22 @@
 import { parseRecipeData } from "~/utils/recipes";
 import type { Meal } from "~/types/recipe";
+import { idSchema } from "~/types/id";
 
 export default defineEventHandler(async (event) => {
   const { apiUrl } = useRuntimeConfig();
-  const id = getRouterParam(event, "id");
+  const routeParam = getRouterParam(event, "id");
+
+  const parsed = idSchema.safeParse(routeParam);
+  if (!parsed.success) {
+    throw createError({
+      statusCode: 400,
+      statusMessage: "Invalid recipe id",
+      message: parsed.error.message,
+    });
+  }
 
   const data = await $fetch<{ meals: Meal[] }>(
-    new URL(`lookup.php?i=${id}`, apiUrl).toString(),
+    new URL(`lookup.php?i=${parsed.data}`, apiUrl).toString(),
   );
   if (!data?.meals) {
     throw createError({
diff --git a/types/id.ts b/types/id.ts
new file mode 100644
index 0000000..4cd795f
--- /dev/null
+++ b/types/id.ts
@@ -0,0 +1,8 @@
+import { z } from "zod";
+
+export const idSchema = z
+  .number({
+    required_error: "recipe id is required",
+    invalid_type_error: "recipe id must be a number",
+  })
+  .positive("recipe id must be positive");