From 6ab5c8afe98d77a29746b4ddc679e00001f6121a Mon Sep 17 00:00:00 2001
From: Ruidy <r.nemausat@empfohlen.de>
Date: Fri, 16 Jul 2021 12:17:37 +0200
Subject: [PATCH] feat: populate edit form with existing data

---
 src/components/billForm.tsx  | 43 ++++++++++++++++-----------------
 src/components/formInput.tsx | 32 +++++++++++++++++++++++++
 src/pages/bill/index.tsx     | 46 ++++++++++--------------------------
 src/pages/home.tsx           |  4 ++--
 4 files changed, 68 insertions(+), 57 deletions(-)
 create mode 100644 src/components/formInput.tsx

diff --git a/src/components/billForm.tsx b/src/components/billForm.tsx
index 7bd082e..ad8c813 100644
--- a/src/components/billForm.tsx
+++ b/src/components/billForm.tsx
@@ -1,37 +1,32 @@
-import { Button, Form, Input, Switch } from 'antd';
+import { Button, Form, Switch } from 'antd';
 import { BaseSyntheticEvent } from 'react';
-import { Control, Controller, UseFormRegister } from 'react-hook-form';
+import { Control, Controller } from 'react-hook-form';
 import { BillFormType } from '../types/bill';
+import { FormInput } from './formInput';
 import { InputSelect } from './inputSelect';
 
 type Props = {
   onFinish: (e?: BaseSyntheticEvent) => Promise<void>;
   control: Control<BillFormType>;
-  register: UseFormRegister<BillFormType>;
 };
 
-export function BillForm({ onFinish, control, register }: Props) {
+export function BillForm({ onFinish, control }: Props) {
   return (
     <Form layout="vertical" onFinish={onFinish}>
-      <Form.Item label="Customer name">
-        <Input placeholder="Cameron Doe" {...register('name')} />
-      </Form.Item>
+      <FormInput control={control} name="name" label="Customer name" placeholder="Cameron Doe" />
 
-      <Form.Item label="Customer phone number">
-        <Input placeholder="06 12 34 56 78" {...register('phoneNumber')} />
-      </Form.Item>
+      <FormInput
+        control={control}
+        name="phoneNumber"
+        label="Customer phone number"
+        placeholder="06 12 34 56 78"
+      />
 
-      <Form.Item label="Price">
-        <Input placeholder="75.00" addonAfter="€" {...register('price')} />
-      </Form.Item>
+      <FormInput control={control} name="price" label="Price" placeholder="75.00" addonAfter="€" />
 
-      <Form.Item label="Start">
-        <Input type="date" {...register('start')} />
-      </Form.Item>
+      <FormInput control={control} name="start" label="Start" type="date" />
 
-      <Form.Item label="End">
-        <Input type="date" {...register('end')} />
-      </Form.Item>
+      <FormInput control={control} name="end" label="End" type="date" />
 
       <InputSelect
         control={control}
@@ -41,9 +36,13 @@ export function BillForm({ onFinish, control, register }: Props) {
         options={['T2 Corail', 'T3 Azur']}
       />
 
-      <Form.Item label="Customers number">
-        <Input type="number" {...register('customers')} placeholder="1" />
-      </Form.Item>
+      <FormInput
+        control={control}
+        name="customers"
+        label="Customers number"
+        placeholder="1"
+        type="number"
+      />
 
       <InputSelect
         control={control}
diff --git a/src/components/formInput.tsx b/src/components/formInput.tsx
new file mode 100644
index 0000000..371058c
--- /dev/null
+++ b/src/components/formInput.tsx
@@ -0,0 +1,32 @@
+import { Form, Input } from 'antd';
+import { Controller } from 'react-hook-form';
+
+type FormInputProps = {
+  control: any;
+  name: string;
+  label: string;
+  placeholder?: string;
+  addonAfter?: string;
+  type?: string;
+};
+
+export function FormInput({
+  control,
+  name,
+  label,
+  placeholder,
+  addonAfter,
+  type = 'text'
+}: FormInputProps) {
+  return (
+    <Controller
+      control={control}
+      name={name}
+      render={({ field }) => (
+        <Form.Item label={label}>
+          <Input placeholder={placeholder} {...field} addonAfter={addonAfter} type={type} />
+        </Form.Item>
+      )}
+    />
+  );
+}
diff --git a/src/pages/bill/index.tsx b/src/pages/bill/index.tsx
index dc8508d..0bee6e4 100644
--- a/src/pages/bill/index.tsx
+++ b/src/pages/bill/index.tsx
@@ -5,8 +5,7 @@ import { useHistory, useParams } from 'react-router-dom';
 import { createBill, fetchOneBill, sendBillAsPDF } from '../../api';
 import { BillForm } from '../../components/billForm';
 import { withLayout } from '../../layouts/main';
-import { Bill } from '../../types/bill';
-import NotFoundPage from '../notFound';
+import { Bill, BillFormType } from '../../types/bill';
 import { BillSent } from './billSent';
 
 export type QueryParams = { id: string };
@@ -15,24 +14,7 @@ const BillPage = () => {
   // Hooks
   const { id } = useParams<QueryParams>();
   const history = useHistory();
-
-  const defaultValues = {
-    customers: 0,
-    start: '',
-    end: '',
-    name: '',
-    paymentMethod: 0,
-    paymentStatus: 0,
-    phoneNumber: '',
-    platform: 0,
-    price: 0,
-    room: 0,
-    taxes: false
-  };
-
-  const { register, handleSubmit, control, reset } = useForm<BillFormType>({
-    defaultValues
-  });
+  const { handleSubmit, control, reset } = useForm<BillFormType>();
 
   // Local State
   const [sent, setSent] = useState(false);
@@ -41,18 +23,16 @@ const BillPage = () => {
 
   // Effects
   useEffect(() => {
-    const loadBIllById = async (id: string) => {
+    (async (id: string) => {
       const billID = parseInt(id);
       const { data: loadedBill, error } = await fetchOneBill(billID);
-      if (!loadedBill || error) {
-        return <NotFoundPage />;
+      if (loadedBill && error) {
+        setBill(() => loadedBill);
+        const { id, ...values } = loadedBill;
+        reset(values);
       }
-      setBill(() => loadedBill);
-      return;
-    };
-
-    loadBIllById(id);
-  }, [id]);
+    })(id);
+  }, [id, reset]);
 
   // Logic
   const handleSendPDF = (id: number) => {
@@ -66,15 +46,15 @@ const BillPage = () => {
   });
 
   const content = edit ? (
-    <BillForm onFinish={onSubmit} control={control} register={register} />
+    <BillForm onFinish={onSubmit} control={control} />
   ) : sent ? (
     <BillSent />
   ) : (
     <Col>
-      <Typography.Text>{bill?.name}</Typography.Text>
-      <Typography.Text>{bill?.price} €</Typography.Text>
+      <Typography.Text>{bill.name}</Typography.Text>
+      <Typography.Text>{bill.price} €</Typography.Text>
       <Typography.Text>
-        from {bill?.start} to {bill?.end}
+        from {bill.start} to {bill.end}
       </Typography.Text>
     </Col>
   );
diff --git a/src/pages/home.tsx b/src/pages/home.tsx
index f07763d..1a85752 100644
--- a/src/pages/home.tsx
+++ b/src/pages/home.tsx
@@ -7,7 +7,7 @@ import { BillFormType } from '../types/bill';
 
 const HomePage = () => {
   // Hooks
-  const { register, handleSubmit, control } = useForm<BillFormType>();
+  const { handleSubmit, control } = useForm<BillFormType>();
   const history = useHistory();
 
   // Logic
@@ -20,7 +20,7 @@ const HomePage = () => {
     <>
       <h1>Create a new bill</h1>
 
-      <BillForm onFinish={onSubmit} control={control} register={register} />
+      <BillForm onFinish={onSubmit} control={control} />
     </>
   );
 };