From 14bb8af68c36878552036d5f0459eaafdab431b4 Mon Sep 17 00:00:00 2001
From: Ruidy Nemausat <ruidy.nemausat@gmail.com>
Date: Mon, 20 Apr 2020 16:18:16 +0200
Subject: [PATCH] fix bug in NewTicket Form

---
 app.db                                        | Bin 106496 -> 106496 bytes
 client/src/components/Lists/ProjectList.tsx   |   1 -
 .../src/components/Modals/NewProjectModal.tsx |   6 +-----
 .../src/components/Modals/NewTicketModal.tsx  |  12 ++++++------
 client/src/components/Panels/UserTabPanel.tsx |   1 -
 client/src/controllers/ProjectController.tsx  |   2 +-
 client/src/controllers/TicketController.tsx   |   2 +-
 client/src/controllers/UserController.tsx     |   2 +-
 8 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/app.db b/app.db
index db588efd185009c6d5b1ada8e2b639e9403f2345..bd6fe13593820a15ee375374784c98f38c453578 100644
GIT binary patch
delta 217
zcmZoTz}9epZNvY3MvhGdEDA#GJkbn%Z+UO=2JkiTPvCjT6TMkbz?CPlk(q;+!C2SP
zn3I!}F_e)ZBqOs}0f-V6N>YnU6iO0{vpq}HfkJr-B^jv-d5O8HMg~R(x&|h?Mg|Io
zW>yB4Rt6?|rsl?$CT4IMV+8{PD==c6tUXtC^TRpHkA>LzZ!++I=l{h2mj4C+WBz;m
zH-Sz#%+Jcg%)rPo{a!z#8c@kq2L6xyZ}^|{f8&41f1Cd*P|1FNHdbavMi!3gx92me
F0sv+bKbHUi

delta 96
zcmZoTz}9epZNvY3M)pkwED8c_JP#T8-tyk!4d83wpTP5Qv!K9Pp3M*EC_ffp<G;ti
z|DFF6|6BeS{EzwX0i{myPrujCs0Ng}&A|VW{|*0h{%`yb`ELWIj`L5yJ)cn(0QLbT
Aod5s;

diff --git a/client/src/components/Lists/ProjectList.tsx b/client/src/components/Lists/ProjectList.tsx
index eaea250..1517b0b 100644
--- a/client/src/components/Lists/ProjectList.tsx
+++ b/client/src/components/Lists/ProjectList.tsx
@@ -11,7 +11,6 @@ import ProjectCard from "../Cards/ProjectCard";
 import FloatingButton from "../Buttons/FloatingButton";
 import NewProjectModal from "../Modals/NewProjectModal";
 import Project from "../../types/Project";
-import User from "../../types/User";
 
 const useStyles = makeStyles((theme: Theme) =>
   createStyles({
diff --git a/client/src/components/Modals/NewProjectModal.tsx b/client/src/components/Modals/NewProjectModal.tsx
index e29fed4..1c1694c 100644
--- a/client/src/components/Modals/NewProjectModal.tsx
+++ b/client/src/components/Modals/NewProjectModal.tsx
@@ -1,12 +1,8 @@
 import React, { FC, useState, FormEvent } from "react";
 import { TextField } from "@material-ui/core";
-import Modal from "./Modal";
-import Project from "../../types/Project";
-import User from "../../types/User";
-import { post } from "../../utils/http";
-import Constants from "../../utils/Constants";
 import { useAuth0 } from "../../authentication/auth0";
 import { ProjectService } from "../../services";
+import Modal from "./Modal";
 
 interface IProps {
   show: boolean;
diff --git a/client/src/components/Modals/NewTicketModal.tsx b/client/src/components/Modals/NewTicketModal.tsx
index 34afeea..972770e 100644
--- a/client/src/components/Modals/NewTicketModal.tsx
+++ b/client/src/components/Modals/NewTicketModal.tsx
@@ -35,9 +35,9 @@ const NewTicketModal: FC<IProps> = ({ show, handleClose, allProjects }) => {
   const { url } = useRouteMatch();
   const id = url.split("/")[2];
   const [projectId, setProjectId] = useState(id);
-  const [categoryID, setCategoryID] = useState(0);
-  const [impactID, setImpactID] = useState(0);
-  const [difficultyID, setDifficultyID] = useState(0);
+  const [categoryID, setCategoryID] = useState(1);
+  const [impactID, setImpactID] = useState(1);
+  const [difficultyID, setDifficultyID] = useState(1);
   const { getTokenSilently, user } = useAuth0();
 
   const handleSubmit = async (e: FormEvent) => {
@@ -157,7 +157,7 @@ const NewTicketModal: FC<IProps> = ({ show, handleClose, allProjects }) => {
           className={classes.select}
         >
           {Category.map((c: string, i: number) => (
-            <MenuItem key={i} value={i}>
+            <MenuItem key={i} value={i + 1}>
               {c}
             </MenuItem>
           ))}
@@ -178,7 +178,7 @@ const NewTicketModal: FC<IProps> = ({ show, handleClose, allProjects }) => {
           margin="normal"
         >
           {Impact.map((c: string, i: number) => (
-            <MenuItem key={i} value={i}>
+            <MenuItem key={i} value={i + 1}>
               {c}
             </MenuItem>
           ))}
@@ -199,7 +199,7 @@ const NewTicketModal: FC<IProps> = ({ show, handleClose, allProjects }) => {
           margin="normal"
         >
           {Difficulty.map((c: string, i: number) => (
-            <MenuItem key={i} value={i}>
+            <MenuItem key={i} value={i + 1}>
               {c}
             </MenuItem>
           ))}
diff --git a/client/src/components/Panels/UserTabPanel.tsx b/client/src/components/Panels/UserTabPanel.tsx
index 839a9de..8674425 100644
--- a/client/src/components/Panels/UserTabPanel.tsx
+++ b/client/src/components/Panels/UserTabPanel.tsx
@@ -6,7 +6,6 @@ import ProjectList from "../Lists/ProjectList";
 import TicketList from "../Lists/TicketList";
 import Ticket from "../../types/Ticket";
 import Project from "../../types/Project";
-import User from "../../types/User";
 
 interface TabProps {
   children?: ReactNode;
diff --git a/client/src/controllers/ProjectController.tsx b/client/src/controllers/ProjectController.tsx
index b439461..a84599e 100644
--- a/client/src/controllers/ProjectController.tsx
+++ b/client/src/controllers/ProjectController.tsx
@@ -72,7 +72,7 @@ const ProjectController: FC = () => {
       setHasError(true);
       setError("Bad Request");
     }
-  }, [id]);
+  }, [id, getTokenSilently]);
 
   if (hasError) {
     return <ErrorController error={error} />;
diff --git a/client/src/controllers/TicketController.tsx b/client/src/controllers/TicketController.tsx
index 264c893..28de0c5 100644
--- a/client/src/controllers/TicketController.tsx
+++ b/client/src/controllers/TicketController.tsx
@@ -38,7 +38,7 @@ const TicketController: FC = () => {
       setHasError(true);
       setError("Bad Request");
     }
-  }, [id]);
+  }, [id, getTokenSilently]);
 
   if (hasError) {
     return <ErrorController error={error} />;
diff --git a/client/src/controllers/UserController.tsx b/client/src/controllers/UserController.tsx
index 8abd9d6..bd7d326 100644
--- a/client/src/controllers/UserController.tsx
+++ b/client/src/controllers/UserController.tsx
@@ -40,7 +40,7 @@ const UserController: FC = () => {
       setHasError(true);
       setError("Bad Request");
     }
-  }, [id]);
+  }, [id, getTokenSilently]);
 
   if (hasError) {
     return <ErrorController error={error} />;