mirror of
https://github.com/rjNemo/underscore
synced 2026-06-06 02:26:42 +00:00
BREAKING CHANGE: Drop function now correctly drops first N elements
instead of removing element at specific index.
Changes:
- Renamed old Drop behavior to RemoveAt function
- Implemented correct Drop semantics (drop first N elements)
- Added comprehensive tests for both functions
Drop (NEW behavior):
- Drop([]int{1,2,3,4,5}, 2) → [3,4,5] (drops first 2 elements)
- Returns empty slice if n >= len(values)
- Returns original slice if n <= 0
RemoveAt (OLD Drop behavior):
- RemoveAt([]int{1,2,3,4,5}, 2) → [1,2,4,5] (removes index 2)
- Returns original slice if index out of bounds
- Pre-allocates with capacity len(values)-1
Tests added:
- Drop: 5 tests (basic, none, all, empty, single)
- RemoveAt: 6 tests (basic, first, last, bounds, empty, single)
Documentation updated:
- README.md: Added RemoveAt to function list
- CLAUDE.md: Marked Drop semantics as fixed
- ACTION_PLAN.md: Updated completion status
Migration guide:
- Old: Drop(slice, index) → New: RemoveAt(slice, index)
- New Drop usage: Drop(slice, n) drops first n elements
Coverage: 98.8% (maintained)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
16 lines
410 B
Go
16 lines
410 B
Go
package underscore
|
|
|
|
// Drop returns a new slice with the first n elements removed.
|
|
// If n is greater than or equal to the slice length, returns an empty slice.
|
|
// If n is less than or equal to 0, returns the original slice.
|
|
func Drop[T any](values []T, n int) []T {
|
|
if n <= 0 {
|
|
return values
|
|
}
|
|
if n >= len(values) {
|
|
return []T{}
|
|
}
|
|
res := make([]T, len(values)-n)
|
|
copy(res, values[n:])
|
|
return res
|
|
}
|